`subxt-core` crate by tadeohepperle · Pull Request #1466 · paritytech/subxt

tadeohepperle · 2024-03-07T17:36:11Z

Introduces a subxt-core crate that provides a no_std compatible subset of subxt's functionality.

core/Cargo.toml

niklasad1 · 2024-03-13T08:55:31Z

core/Cargo.toml

+[features]
+default = ["std"]                                                                                                                                                # "std"
+std = [
+    "scale-info/std", 


why are not all crates that has default-features = false added here?

For instance codec/std is not enabled and many more....

core/README.md

core/src/client/mod.rs

jsdw · 2024-03-20T16:26:45Z

subxt/src/client/offline_client.rs

    /// Return the provided [`RuntimeVersion`].
    fn runtime_version(&self) -> RuntimeVersion;
+    /// Return the [subxt_core::client::ClientState] (metadata, runtime version and genesis hash).
+    fn client_state(&self) -> ClientState<T>;


If we have this method, then let's give it a default impl too since it's just a concat of a few of the above :)

jsdw · 2024-03-20T16:28:05Z

subxt/src/client/online_client.rs

+
+    /// Return the [subxt_core::client::ClientState] (metadata, runtime version and genesis hash).
+    pub fn client_state(&self) -> ClientState<T> {
+        let inner = self.inner.read().expect("shouldn't be poisoned");


I guess even with a default impl we'll want this bit anyay though to avoid multiple locks, but it could be seen as an optimisation anyway, so it's all good :)

jsdw · 2024-03-20T16:37:38Z

This is great stuff; left another round of comments but all pretty minor things, and we can thing more about docs etc later :)

@tadeohepperle if you have time to address the small comments and get things compiling then I'm happy to see this merge now!

niklasad1 · 2024-03-22T12:38:32Z

core/src/constants/constant_address.rs

@@ -31,22 +33,15 @@ pub trait ConstantAddress {
 #[derivative(
    Clone(bound = ""),
    Debug(bound = ""),
-    Eq(bound = ""),
-    Ord(bound = ""),


no Ord impl anymore?

niklasad1 · 2024-03-22T12:46:42Z

core/src/custom_values/custom_value_address.rs

 /// A static address to a custom value.
 #[derive(Derivative)]
 #[derivative(
    Clone(bound = ""),
    Debug(bound = ""),
-    Eq(bound = ""),
-    Ord(bound = ""),


same here no Ord?

niklasad1 · 2024-03-22T12:56:54Z

testing/integration-tests/src/full_client/codegen/polkadot.rs

Is these changes related to this refactoring? Lots of changes at least

Yeah, there should be a lot of changes, because we use a lot of types from subxt_core now instead of pulling them from subxt. Additionally we use rust prelude types from alloc instead of from std.

niklasad1 · 2024-03-22T13:01:11Z

testing/no-std-tests/Cargo.toml

I'm pretty slow and don't understand the comment!

I suppose you mean that we don't test that the generated code is no-std?

Oh this should be removed, we now test that the generated code compiles in no-std.

niklasad1

awesome, great job.

just some small comments

tadeohepperle · 2024-03-22T14:24:48Z

We need another fix in scale-typegen for the ui tests to succeed: paritytech/scale-typegen#23
@jsdw @niklasad1

…ical warnings

Polkadot-Forum · 2024-04-04T08:02:55Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/parity-tech-update-for-march/7226/1

tadeohepperle and others added 16 commits February 28, 2024 13:23

start migrating, broken

28f6ceb

first iteration of updating

75caf56

fmt and clippy

7907468

Merge branch 'master' into tadeohepperle/scale-type-resolver-integration

33af807

Merge branch 'master' into tadeohepperle/scale-type-resolver-integration

1b822f8

Merge branch 'master' into tadeohepperle/scale-type-resolver-integration

03127c7

add Composite<u32> decoding via scale value patch

f07813f

bump scale type gen versions

3f6fa39

Merge branch 'master' into tadeohepperle/scale-type-resolver-integration

fd8458b

fix decoding with new scale decode

400f379

compiling with changed deps

022892f

core utils, condig, client, metadata

0922672

core crate compiling

37ee03e

signer crate no once lock

78bc368

add core to no-std-tests, change imports

0cf6f57

broken commit, start pulling everything together in subxt

9c541e0

tadeohepperle mentioned this pull request Mar 7, 2024

[WIP] Subxt-Core Crate #1411

Closed

tadeohepperle added 7 commits March 11, 2024 17:20

port more things to subxt

95e6711

events in core crate, extrinsics sadly much more difficult

1773021

almost all examples pass again

2be1d7a

dynamic values fix in examples

535c28b

fix no std issue and fmt

5e8f2f4

remove unused dependencies

0c4bbc0

fix lightclient impl

b499239

niklasad1 reviewed Mar 13, 2024

View reviewed changes

core/Cargo.toml Outdated Show resolved Hide resolved

Merge branch 'master' into tadeohepperle/subxt-core-3

116b800

niklasad1 reviewed Mar 13, 2024

View reviewed changes

core/README.md Outdated Show resolved Hide resolved

niklasad1 reviewed Mar 13, 2024

View reviewed changes

core/src/client/mod.rs Outdated Show resolved Hide resolved

niklasad1 reviewed Mar 13, 2024

View reviewed changes

core/src/client/mod.rs Outdated Show resolved Hide resolved

jsdw reviewed Mar 20, 2024

View reviewed changes

remove std traits, use core traits instead

5caed4a

tadeohepperle added 6 commits March 21, 2024 10:30

address nits

6cd17e6

remove unusued dep in no-std tests

1ad09f4

fix Box import in no_std

c1a2e3f

Merge branch 'master' into tadeohepperle/subxt-core-3

3051462

sp-crypto-hashing instead of sp-core-hashing

e273363

bump scale-typegen, add no std codegen tests

1ba372a

tadeohepperle mentioned this pull request Mar 22, 2024

Remove ensure_unique_type_paths function from subxt_metadata, use it from scale-typegen instead. #1487

Closed

niklasad1 reviewed Mar 22, 2024

View reviewed changes

niklasad1 approved these changes Mar 22, 2024

View reviewed changes

fix some things

b2aa59e

jsdw added 7 commits March 25, 2024 14:08

Merge branch 'master' into tadeohepperle/subxt-core-3

95ef002

replace unmaintained derivative with derive_where to remove non-canon…

88c3cee

…ical warnings

fmt

0aebf5e

remove unused dep

c36c018

fix deps

60ef594

update artifacts to fix type ID mismatches

519a107

bump to latest scale-typegen

7fb423d

jsdw approved these changes Mar 27, 2024

View reviewed changes

jsdw merged commit a0cb14a into master Mar 27, 2024

jsdw deleted the tadeohepperle/subxt-core-3 branch March 27, 2024 08:55

jsdw mentioned this pull request May 16, 2024

Prep for 0.36.0 release #1587

Merged

Conversation

tadeohepperle commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsdw commented Mar 20, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

niklasad1 Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

niklasad1 left a comment

Choose a reason for hiding this comment

Uh oh!

tadeohepperle commented Mar 22, 2024

Uh oh!

Polkadot-Forum commented Apr 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tadeohepperle commented Mar 7, 2024 •

edited

Loading

niklasad1 Mar 22, 2024 •

edited

Loading